archetech / archon / 33270033065

87%

push

github

perf(ci): Use the sqlite3 prebuild in the chain mediators (#961)

* perf(ci): Use the sqlite3 prebuild in the chain mediators

Three Dockerfiles ran `npm rebuild sqlite3 --build-from-source`, which
throws away the prebuilt binary that scripts/prefetch-prebuilds.mjs
seeded moments earlier and compiles SQLite's C source instead. Under
emulation that is expensive, and those three were the slowest Node images
in the publish by roughly double:

  zcash-mediator     29m      satoshi-mediator   13m
  solana-mediator    30m
  ethereum-mediator  30m

satoshi is the control. It depends on sqlite3, uses the same base image
and the same build shape, does not force a source build, and takes less
than half as long.

The line predates the mechanism that made it unnecessary. It arrived in
#536 on 19 May with no comment and no note in the PR, was copied verbatim
into #543 and #544, and prefetch-prebuilds.mjs did not exist until #879
on 13 August. Forcing a source build in May sidestepped a fetch that had
no retry -- which is the same failure #879 later fixed properly.

Verified on zcash before touching the other two: the image builds without
the line, and sqlite3 loads and runs inside it, opening a database and
creating a table rather than merely being present. A prebuild with the
wrong ABI installs cleanly and throws at require(), so building was not
sufficient evidence on its own.

Only zcash was exercised at runtime. The other two are
character-identical copies of the same line against the same dependency.

* fix(ci): Seed every installed prebuild version, not just the root's

The prefetch script read package-lock.json and nothing else, and the
seeded filename carries the package version. The mediators pin their own:
satoshi installs sqlite3 5.1.7, matching the root, while zcash, solana
and ethereum install 6.0.1 and got nothing.

That matters for the sibling commit here. Removing `npm rebuild sqlite3
--build-from-source` from those three was justified by satoshi w... (continued)

3880 of 4464 branches covered (86.92%)

Branch coverage included in aggregate %.

8527 of 8952 relevant lines covered (95.25%)

717.63 hits per line