umputun / remark42 / 33264468282
85%
master: 85%

LAST BUILD BRANCH: e2e-covers-more
DEFAULT BRANCH: master
Ran
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.427%. Remained the same
33264468282

Pull #2232

github

paskal 
Report what the browser suite reaches in the backend

The e2e suite drives the real binary through a browser and its coverage was
counted nowhere, so packages it exercises heavily read as untested. The code
runs in a container instead of in the test process, which is why go test
-cover cannot see it.

make e2e-cover overlays the stack with compose-e2e-coverage.yml, which builds
the image with go build -cover and mounts a profile directory per instance,
then e2e/coverage.sh runs the suite, stops the instances so the profiles
flush, merges them into e2e/coverage/e2e.cov and prints the total. Across the
seven remark42 instances the suite reaches 37% of backend statements.

The overlay is a separate file because a bind mount in the short form creates
its host path when it is missing, so carrying it in compose-e2e-test.yml would
have an ordinary run create the directory, owned by whatever the daemon runs
as. A plain run leaves no trace of coverage.

Three ways this could report nothing and still look like a result, so each
fails instead. Every instance directory is checked and not the total, because
six clean exits and one killed instance merge into a plausible report with
that instance reading as unreached. The suite's exit status is kept but the
stop and the merge happen either way, so a failing run does not discard the
coverage that would explain it. And E2E_COVERAGE feeds the source stamp as
well as the image build, so the two stacks carry different stamps and the
suite refuses the one it was not built for; only the value 1 instruments, in
the stamp and the Dockerfile alike, so turning it off cannot turn it on.

The profile is written in atomic mode, which is also the only mode -race
accepts, and with the same _mock.go exclusion the unit run applies, so the two
can be reported as one figure. The instrumentation is a build argument, off by
default, so a published image is unaffected.
Pull Request #2232: Report what the browser suite reaches in the backend

6665 of 7802 relevant lines covered (85.43%)

38.29 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33264468282.1 54
85.43
 GitHub Action Run
Source Files on build 33264468282