CyclopsMC / IntegratedDynamics / 33258224303

47%

master-1.21-lts: 47%

Pull #1707

github

Make the aspect properties tooltip independent of gui value syncing

The values that are shown in the aspect properties tooltip of the part gui
were fully determined by the values that the server syncs to the container.
They are now also determined client-side, from the part state, which is
known on both sides:

* Properties that hold a variable in their setting slot are always shown,
  as the part state contains the variable slots of all aspects.
  The value that the variable produces is layered on top of this
  as soon as the server syncs it.
* The errors of aspect setting variables are now stored inside the part state,
  just like the offset variable errors already were,
  so that the tooltip can render erroring values in red without any syncing.
  An update is sent to the client whenever such an error appears or disappears.

Determining the shown values also no longer fails when the part
disappears while its gui is open.

Adds game tests for the full server-to-client path of these values:
the server-side container broadcasting them, the value ids they are
synced under being identical on both sides, the client-side container
showing them, and the fallbacks when nothing was synced (yet).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SEB2eDBd8VaFgqeJRwaSyk

3020 of 9194 branches covered (32.85%)

Branch coverage included in aggregate %.

12844 of 24704 relevant lines covered (51.99%)

2.49 hits per line