GollumSF / rest-bundle / 33255798331

100%

master: 100%

push

github

Count and paginate correctly across a to-many join

Joining a to-many relation multiplies the SQL rows, which showed up twice.

The total counted rows instead of entities: on the test fixtures, 40 authors joined to
their books were counted 56 as soon as a query callback joined the collection. The count
is now taken DISTINCT.

The limit applied to those multiplied rows, so a page came back short: asking for 5
authors ordered by id returned 4, and whether it happened depended on where the duplicate
rows fell in the window. A path crossing a collection is now ordered on an aggregate of
the joined column, MIN ascending and MAX descending, grouped by the identifier of the root
entity, which removes the fan-out altogether.

Doctrine's Paginator would have fixed both, but it rewrites the query into subqueries and
falls over on a query callback that already grouped or made the query distinct. Adding an
aggregate only ever adds to the query builder, so existing callbacks keep working, and it
still takes two queries.

Ordering on a plain column or across a to-one relation is untouched.

31 of 31 new or added lines in 1 file covered. (100.0%)

1053 of 1053 relevant lines covered (100.0%)

30.38 hits per line