NVIDIA / nodewright / 33223440233
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.491% (-0.1%) from 82.599%
33223440233

push

github

web-flow 
fix(licenses): disclose all vendored modules and make notices deterministic (#557)

* fix(licenses): disclose all vendored modules and make notices deterministic

The go-licenses --ignore list was built from the first path segment of every
stdlib package, so go/ast collapsed to the bare token "go". --ignore matches by
prefix, so that token also matched every vendored module under
go.opentelemetry.io, go.uber.org, golang.org/x, google.golang.org, gomodules.xyz
and gopkg.in. 31 of the operator's vendored modules were silently dropped from
operator/THIRD_PARTY_NOTICES.md and the root rollup while still being
redistributed in the released images. No error was raised: go-licenses was asked
about the packages, told to ignore them, and correctly reported nothing.

Pass full stdlib package paths instead. No stdlib package path is a prefix of a
third-party module path, so the collision cannot recur. Recompute the set per
target platform, because platform-specific stdlib packages such as
internal/syscall/windows only exist under their own GOOS and go-licenses fails
outright when they are missing from the ignore list.

Collect per released platform and union the results. The operator image is
linux-only, but the CLI ships linux/darwin/windows x amd64/arm64, and
build-tagged sources pull different transitive dependencies per platform:
github.com/Azure/go-ansiterm and github.com/inconshreveable/mousetrap are linked
only on windows and were undisclosed for that reason as well. Give each platform
its own license-file cache: `go-licenses save --force` removes its --save_path
first, so a single shared directory keeps only the last platform's artifacts and
a package present on linux but not windows (golang.org/x/sys/unix,
github.com/prometheus/procfs) loses its license text while keeping its index
row. The operator index goes from 92 to 123 entries.

Bump go-licenses to v2.0.1. v1 picks one license at random from a file that
contains several, so sigs.k8s.io/yaml, sigs.... (continued)

9168 of 11114 relevant lines covered (82.49%)

7.64 hits per line

Coverage Regressions

Lines Coverage ∆ File
15
78.75
 -0.6% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 33223440233.1 59
82.49
 GitHub Action Run
Source Files on build 33223440233