solidjs / solid / 33192724225

72%

main: 89%

push

github

fix(web): fail a call on a response the runtime did not write (#3088)

* fix(web): fail a call on a response the runtime did not write (#3087)

Only the protocol's error header and a 5xx counted as failure, so every other
non-2xx was decoded as a result — and decoding a login page, or an empty 405,
yields nothing. The call resolved to `undefined`, reading as "the function
returned nothing" where the request had not reached it.

A response at 300 or above carrying neither the error header nor a body format
now fails the call with the status on the error. Undecoded, because its body
is someone else's; and before the passthrough that control flow uses, because
a foreign refusal carries a `Location` of its own often enough — an SSO
interstitial is exactly that — that the passthrough would have swallowed it.
The runtime never puts a redirect on the wire as a 3xx, so nothing of its own
falls in the range.

`BodyFormat.Void` marks the one response the runtime encodes without a format
to carry, so a void result with a status stays a result, matching what the
equivalent bare `Response` already did.

* fix(web): leave redirects to the passthrough

The check covered 300 and up, on the reasoning that an SSO interstitial
answers a refusal with a `Location` of its own. Driving a browser against a
real origin says otherwise: `fetch` follows redirects, so the interstitial
arrives as its login page at 200, and `redirect: "manual"` yields an
opaqueredirect at status 0 — neither is a 3xx by the time the transport sees
it. The clause only ever fired server-side, in tests, and on synthesized
responses.

What it cost there was real: a verbatim `X-Content-Raw` passthrough carrying a
`Location` — the documented escape hatch for answering a call with a response
of one's own — stopped reaching the caller, and a `live()` source facing a
foreign 3xx reconnected forever instead of ending, because the retry
classifier reads 4xx as definite and everything else as transient.

Back t... (continued)

517 of 782 branches covered (66.11%)

Branch coverage included in aggregate %.

767 of 996 relevant lines covered (77.01%)

14.64 hits per line