solidjs / solid / 33189991920

72%

main: 89%

push

github

feat(web): let an app supply the fetch server function calls go through (#3080)

* feat(web): let an app supply the fetch server function calls go through

The transport sends every call with the global `fetch`.
`configureServerFunctionsClient({ fetch })` replaces it: retries, telemetry, a
test double, or a route of the app's own.

An app-shaped url — an argument in a path segment, a tenant in a prefix —
cannot be a second built-in address without teaching every gate that
recognises a call: the runtime, the plugin's dev middleware, the generated
dispatch gate, the router's action-url interception. It does not have to be
one. The handler takes a web `Request`, so an app route that rewrites into the
canonical address dispatches like any other call, and the client's side of it
was the only piece missing.

The seam is typed and called as `(address, init)`, including on the path where
call observers are installed — that path used to hand the global `fetch` a
`Request`, and keeping the difference would mean a wrapper written against the
documented shape silently misrouting the moment devtools attached. Observers
receive a reconstruction of the dispatched request. `null` restores the
global, and a wrapper that answers with anything but a `Response` is told so
by name rather than through a property read on undefined.

Also tidies the `endpoint` docs on both entries, which the path-addressing
change left saying the same thing twice.

* fix(web): keep observers out of the way of the call they observe

Review of the seam turned up two things the observed path got wrong, both
introduced by giving it the same `(address, init)` shape as the path without
observers.

The reconstructed `Request` was built from the live `init`, so a streaming
body was disturbed before the send got it — a call that worked without
devtools failed with them attached. It is now built without a streaming body,
and skipped altogether if the init will not make a `Request` at all: an init
the ... (continued)

517 of 782 branches covered (66.11%)

Branch coverage included in aggregate %.

767 of 996 relevant lines covered (77.01%)

14.64 hits per line