FEniCS / ffcx / 33189579632

86%

main: 85%

Build Type

Pull #865

github

Committed by garth-wells

Commit Message

Address review nits: expr_key naming, rounding doc, dead table_access call

- Rename optimizer.py's _key to expr_key since it's imported into
  integral_generator.py; add an explicit PrefixUnaryOp case so Neg/Not
  subexpressions key structurally instead of falling through to a
  default identity-based repr().
- Correct reciprocal_cse_statements' docstring: a * (1.0 / b) is not
  bit-identical to a / b in general (two roundings, not one), except
  when b is an exact power of two -- it's the same reassociation
  -ffast-math would apply, done unconditionally here, not a rounding-
  preserving transform.
- Move the tensor-factorisation table_access call in
  _define_coordinate_dofs_lincomb into the branch that actually uses
  it; the unrolled branch was computing and discarding it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #865: Stack codegen performance fixes: quadrature-loop split, tensor contraction, CSE, coordinate unrolling, LICM fusion

Coverage Stats

279 of 322 new or added lines in 4 files covered. (86.65%)

39 existing lines in 7 files now uncovered.

4476 of 5272 relevant lines covered (84.9%)

0.85 hits per line