Giorgi / DuckDB.NET / 33165511888

88%

Build Type

push

github

Committed by Giorgi

Commit Message

Make GetFieldValue<object> return the same value as GetValue

DbDataReader defines GetFieldValue<T> as (T)GetValue(ordinal), so
GetFieldValue<object> is the ADO.NET spelling of "the default value",
and providers such as Npgsql honour it. Here the request fell through to
the vector readers, which served object inconsistently: numeric and
hugeint columns threw InvalidCastException, enums threw
NullReferenceException, timestamps and dates returned native structs,
structs returned an empty object, lists and maps threw, and nulls threw
instead of returning DBNull.

Route object requests through GetValue at the reader level, which the
scalar function parameter path already did. Nested object targets such
as List<object> stay rejected, since only the top-level object has a
defined meaning.

Coverage Stats

1586 of 1883 branches covered (84.23%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

12 existing lines in 2 files now uncovered.

3161 of 3492 relevant lines covered (90.52%)

250660.27 hits per line