zostera / django-bootstrap3 / 33146955671

78%

push

github

Remove unused GDAL install from CI and stale commented-out GIS test (#1140)

The `polygon = gisforms.PointField()` test field was added in 2017
(cf7a7eb) to reproduce Django ticket #28105, a crash in
BaseGeometryWidget.get_context() when attrs contained a key already in
the widget context. It was commented out pending the upstream fix:

    # TODO: Re-enable this after Django 1.11 #28105 is available

That fix shipped in Django 1.11.x. This repo now tests Django 5.2 to
6.1, so the TODO has been stale for years. The line also references
`gisforms`, which is not imported here, so it could not be uncommented
as-is.

The GDAL apt steps sit in the `build` job, which runs `just build` and
no tests, so they have been installing GDAL for nothing. Nothing else in
this repo references contrib.gis, gdal, or geos, and tests run on
sqlite3 in memory.

Removing the apt steps also removes a hang risk: the same
`sudo apt-get update` step in django-bootstrap4 stalled on an
unreachable Ubuntu mirror and burned six hours of runner time.

Keeping the equivalent coverage in django-bootstrap4, which genuinely
uses contrib.gis, and adding it to django-bootstrap5 separately.

Verified: `just lint` passes, 65 tests pass, ci.yml still parses with
all five jobs.

162 of 250 branches covered (64.8%)

Branch coverage included in aggregate %.

610 of 736 relevant lines covered (82.88%)

11.6 hits per line