Qiskit / qiskit / 33120356236

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add impls of ProgramNode for various math operations (#16107)

* Add impls of ProgramNode for various math operations

* Make binary bitwise ops check broadcasting

* add a macro to help with call_flat arg unpacking

* change namespace of math nodes from "math" to "qiskit"

* Remove tensor::cast_ref()

This function was introduced before we switched to ArcTensor. Now
there is no real point to it, since we don't need to be scared of
cloning tensors; cast_ref would just be switching one box for another.

* Update crates/providers/src/program_node.rs

* Add checks for out-of-bounds dimensions

* Switch to a flat public namespace

* Add some e2e call() tests

* clippy

* Apply suggestions from code review re: &str

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Apply suggestions from code review re: inplace arary ops

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Revert "Apply suggestions from code review re: inplace arary ops"

This reverts commit 0dc1c024e.

* improve memory and speed of complex reductions

* Apply suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Expand reduction test coverage

This commit expands the test coverage of the reduction module to make
sure all the code paths are exercised and validated. It was mostly dtype
coverage for all the math nodes that was missing. The other piece was
the optimizations added aea04da13 the
accumulation path was not covered so a test was added and compared
against the result from ndarray's var axis.

* Fix rustfmt

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Coverage Stats

818 of 965 new or added lines in 5 files covered. (84.77%)

11 existing lines in 2 files now uncovered.

115018 of 131079 relevant lines covered (87.75%)

981679.02 hits per line