block / mysql / 33120091003

83%

master: 83%

Build Type

Pull #2

github

Committed by morgo

Commit Message

fix: keep the warning count until the next command

clearResult() was the wrong reset point. It runs at the start of every
statement, but it also runs from (*mysqlRows).Close — after skipRows has
already read the packet that carries the count. A caller that closes a
resultset without draining it (a proxy forwarding rows elsewhere) had the
count zeroed out from under it before it could read it.

Reset in resetSequence() instead: sending a command is what ends the
previous statement's diagnostics, which is the semantic the count is
supposed to follow anyway.

The existing integration coverage missed this because draining to EOF
nils out rows.mc, so Close returns early and never reaches clearResult.
Cover the undrained path too, plus a unit test pinning that clearResult
specifically does not touch the count.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Pull Request Pull Request #2: conn: expose the OK/EOF packet warning count

Coverage Stats

34 of 34 new or added lines in 3 files covered. (100.0%)

4 existing lines in 1 file now uncovered.

3451 of 4175 relevant lines covered (82.66%)

2569384.31 hits per line