block / mysql / 33119442546

83%

master: 83%

Build Type

Pull #2

github

Committed by morgo

Commit Message

review: correct the warning-count lifecycle docs

Both comments on the PR were right, and both were about wording that
described an earlier draft rather than the code.

handleOkPacket no longer has a statusMoreResultsExists early return, so
"recorded before the more-results check" described a check that is not
there. Say what the code now does and why: the count is recorded
unconditionally so each statement of a multi-statement leaves its own
behind.

Warnings() claimed a failed statement leaves the *previous* count in
place. It does not: clearResult() zeroes the count when the failing
statement starts, and an error packet carries no count, so a standalone
failure reports zero. The previous-count case is real only inside a
multi-statement, where the last successful statement's OK packet already
recorded one. Both cases are now stated, and the standalone one is
pinned by a test.

Pull Request Pull Request #2: conn: expose the OK/EOF packet warning count

Coverage Stats

29 of 29 new or added lines in 3 files covered. (100.0%)

189 existing lines in 2 files now uncovered.

3450 of 4170 relevant lines covered (82.73%)

2572367.68 hits per line