humanspeak / svelte-headless-table / 33085356528

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat(view-model): survive column rebuilds without losing plugin state (#297)

* feat(virtual-scroll): export row props and range context types

`addVirtualScroll` is the only plugin whose types live in a separate
`.types.ts`, so its public surface is a hand-maintained re-export list
rather than the automatic `export *` the other plugins get. That list
had drifted and was missing two of the six types it declares:

- `VirtualScrollRowProps`, the shape of the props the plugin adds to
  `tbody.tr` — consumers had to redeclare it locally to type the bag.
- `RangeChangeContext`, the second argument to `onRangeChange` — needed
  to type a handler once it is lifted out into a named function.

Purely additive; no existing export changed.

* test(virtual-scroll): cover state loss across a view model rebuild

Failing tests, ahead of hoisting the plugin's container-bound state to
the config closure.

`createViewModel` instantiates every plugin, so a consumer whose column
array is derived mints a fresh instance per rebuild. Svelte actions bind
at mount and ignore a changed function identity, so the container stays
wired to an instance nothing reads: `scrollContainer` is null and
`viewportHeight` is 0, collapsing the visible range to the buffer.

Asserts the action identity, viewport height, scroll position, visible
range and measured heights all survive a rebuild; that re-attaching
reconciles a fresh node against the retained scroll position; and the
single-table contract that sharing the state implies.

* fix(virtual-scroll): hoist geometry to the config closure

The plugin was a two-level factory whose inner level held every piece of
state that matters — scroll position, viewport height, the height cache,
the container reference and the action itself. `createViewModel` calls
that inner level once per build, so a consumer whose column array is
derived minted a fresh instance on every rebuild.

Svelte binds an action at mount and ignores a changed function identit... (continued)

Coverage Stats

569 of 720 branches covered (79.03%)

Branch coverage included in aggregate %.

183 of 209 new or added lines in 3 files covered. (87.56%)

2 existing lines in 1 file now uncovered.

1494 of 1719 relevant lines covered (86.91%)

20445.58 hits per line