MapColonies / shigola / c5bac289c

44%

Build Type

push

github

Committed by web-flow

Commit Message

feat(server): serve tiles only through the OGC surface (MAPCO-11483, MAPCO-11484, MAPCO-11485) (#9)

* feat(server): remove the capabilities endpoints

The two non-standard capabilities endpoints go. Service and map discovery are
the OGC landing page, /conformance and /collections, which cover the same ground
in standard form, and a map's TileJSON is
/collections/{map}/tiles/{tileMatrixSetId}?f=tilejson.

Both routes are unregistered, not merely unhandled: TestCapabilitiesRemoved asks
the router for every spelling either endpoint answered on -- /capabilities/:map_name
matched with and without an extension, because the handler split the extension
off the parameter itself rather than routing on it.

The map style endpoint survives this change (MAPCO-11485 removes it) and named
the capabilities document as its vector source, so it now names the OGC tileset
resource for the map's default scheme -- the same scheme the capabilities
document described. Without that it would have served a document pointing at a
404. The debug parameter is deliberately not carried into that URL: the OGC
surface has no debug layers, so it would name a parameter the target ignores.

Two pieces of machinery that existed only to build these responses go with them,
which is why this is one commit and not three:

- server.TileURLTemplate and its TileURL* constants. Their only non-test callers
  were the two handlers; what remained was a type exercised solely by its own
  test.
- server.Version. HandleCapabilities was its only reader, so it was left a
  write-only package variable, still assigned by both entrypoints. Its comment
  claimed "various Middleware" used it; none did.

The TileJSON package is untouched. All three members the review.md remediation
added -- TileJSON.CRS, TileJSON.TileMatrixSetID and VectorLayer.Fields -- are set
by server/ogc/tilejson.go and asserted by the OGC tests, so none of them was
capabilities-only. The ticket anticipated otherwise.

TestOGCMount's "th... (continued)

Coverage Stats

32 of 46 new or added lines in 6 files covered. (69.57%)

1 existing line in 1 file now uncovered.

9280 of 19693 relevant lines covered (47.12%)

210.18 hits per line