MapColonies / shigola / 716fbf27a

47%

master: 47%

Build Type

Pull #9

github

Committed by NivGreenstein

Commit Message

test(server): stop asserting that removed routes are absent

TestRouterSurface's "nothing outside it answers" case listed twelve paths this
fork used to serve -- /capabilities, /maps/..., /viewer -- and asserted each
404s. On a branch removing those routes that was evidence. On master it is not a
test of this code: the router registers no catch-all, so any unregistered path
404s whatever we do, and nothing would lead anyone back to those paths for it to
catch. It costs a reader twelve lines of dead surface to read past.

What remains is the half that tests something: every resource NewRouter
registers is reachable through it. That is not implied by anything -- a handler
registered at a path with a typo, or never registered, is not a compile error,
and the ogc package's own tests mount its routes themselves rather than through
NewRouter, so this is the only place the assembled surface is exercised.
Mutation-verified: dropping /tileMatrixSets from the OGC route table fails it.

Consequence worth recording, since the tickets in this PR each have a 404
acceptance criterion: none of them now has an executable assertion. The
behaviour is unchanged and follows from the routes being unregistered, which is
visible in NewRouter -- but nothing tests it, deliberately, and the tickets say
so.

Pull Request Pull Request #9: feat(server): serve tiles only through the OGC surface (MAPCO-11483, MAPCO-11484, MAPCO-11485)

Coverage Stats

32 of 46 new or added lines in 6 files covered. (69.57%)

1 existing line in 1 file now uncovered.

9280 of 19693 relevant lines covered (47.12%)

210.15 hits per line