• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 33016973429
86%

Build:
DEFAULT BRANCH: main
Ran 26 Aug 2026 09:51PM UTC
Jobs 1
Files 257
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

26 Aug 2026 09:47PM UTC coverage: 87.78% (-0.003%) from 87.783%
33016973429

push

github

web-flow
Validate the limit of ProtobufFeature (#4888)

Fixes #4887.

This PR applies the #4862 model to `ProtobufFeature`:

- The constructor now rejects a `maxMessageLength` that is a negative
value other than `-1` with an `ArgumentOutOfRangeException`. `0` remains
valid: an all-defaults Protobuf message encodes to 0 bytes.
- `IProtobufFeature.MaxMessageLength` documents the implementation
contract (a value greater than or equal to `0`), and
`ProtobufFeature.MaxMessageLength` inherits these docs and documents its
default value.

The `MaxMessageLength` read sites were reviewed for `maxSize + 1`-style
overflow: there is none — `DecodeMessageLength` compares the wire length
against `(uint)maxMessageLength` directly, and its safety comment
already relies on the non-negative contract that the interface now
documents. This is also why the valid range has no `int.MaxValue`
exclusion, unlike `maxPayloadSize` in `IceFeature`.

## What's Changed entry

None — only rejects invalid configurations that no reasonable program
uses.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

0 of 5 new or added lines in 1 file covered. (0.0%)

17 existing lines in 5 files now uncovered.

12406 of 14133 relevant lines covered (87.78%)

3019.27 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
15.79
-5.64% src/IceRpc.Protobuf/Features/ProtobufFeature.cs

Coverage Regressions

Lines Coverage ∆ File
5
81.72
-1.39% src/IceRpc/ClientConnection.cs
5
91.4
-0.9% src/IceRpc/Server.cs
3
71.39
-0.8% src/IceRpc/ConnectionCache.cs
3
91.38
-0.32% src/IceRpc/Internal/IceRpcProtocolConnection.cs
1
15.79
-5.64% src/IceRpc.Protobuf/Features/ProtobufFeature.cs
Jobs
ID Job ID Ran Files Coverage
1 33016973429.1 26 Aug 2026 09:51PM UTC 3841
15.58
GitHub Action Run
Source Files on build 33016973429
  • Tree
  • List 257
  • Changed 207
  • Source Changed 1
  • Coverage Changed 207
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #33016973429
  • 87c6376f on github
  • Prev Build on main (#33005782383)
  • Next Build on main (#33079787710)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc