dblock / hashie / 33013822341

98%

master: 98%

push

github

Fix Dash#deep_transform_keys raising for required properties on Rails 7+

ActiveSupport 7's Hash#deep_transform_keys/deep_transform_keys!
build up their result by calling self.class.new with no arguments,
then filling in transformed keys one at a time. For Hashie::Dash
(and Trash), calling .new with no arguments immediately raises
ArgumentError for any required property, since Dash validates
required properties are set at initialization time, long before
any keys can be assigned.

Additionally, deep-transforming a Dash's keys (e.g. stringifying
them) doesn't produce a meaningful Dash anyway, since Dash only
allows setting predefined (symbol) properties.

Fix by overriding Dash#deep_transform_keys to operate on the plain
Hash representation (via #to_h) instead of trying to rebuild a Dash,
using an internal helper equivalent to ActiveSupport's own
implementation so this works whether or not ActiveSupport is loaded.

Also un-pends the previously pending Rails 7 integration spec for
this behavior added in #569.

Closes #559

25 of 26 new or added lines in 2 files covered. (96.15%)

4212 of 4282 relevant lines covered (98.37%)

91.9 hits per line