bleedingdeacons / scrutiny / 33010207558
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 28
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.515% (+0.4%) from 92.07%
33010207558

push

github

web-flow 
feat: audit home group, intergroup position and GSR assignment (#70)

* feat: audit home group and intergroup position assignment

Assigning a member to a home group, moving them between groups, giving them
an intergroup service position or taking one away left no trace in the audit
log. Every other tracked field on a member did. Now each of those writes an
entry.

Both are recorded by name, not merely as "something changed". Neither is
personal data - a group and a service position are public entities that
identify nobody - so the same reasoning that lets the responder-certification
stage record its new value applies here, and an entry that did not say which
group or which position would answer nothing an auditor asked of it. They are
kept out of ALL_FIELDS, CONFIG_KEY_MAP and CONFIG_ACF_KEY_MAP for the same
reason RESPONDER_CERTIFICATION is: they must never be obscured, and reading
one is not a view event.

Entries are written at all three points a role can move. On an edit, via
unity/member_changing, one entry per role and only when that role's ID
actually changed. On creation, because a member created straight into a
position would otherwise be recorded vacating one the log never saw them
take - at most two extra rows, and only when the role was filled, so not the
spam the all-fields sentinel exists to prevent. On deletion, so a position's
history closes rather than trailing off at the last assignment.

Details are terse, because the action and field columns sitting beside them
already say what kind of event it is: `Assigned: Sunday Steps`,
`Thursday Big Book -> Sunday Steps`, `Removed: Sunday Steps`. The deletion
entries are phrased identically to an ordinary removal; their action column
is what marks them as deletions, and a "(member deleted)" suffix said it
twice. The one-sided cases keep a verb only because a bare arrow reads as a
truncated cell.

Names come from the group and position repositories, which AuditTracker now
takes. Unity's own ch... (continued)

2064 of 2231 relevant lines covered (92.51%)

8.05 hits per line

Coverage Regressions

Lines Coverage ∆ File
55
57.49
0.52% scrutiny/scrutiny/src/Plugin.php
2
73.33
0.0% scrutiny/scrutiny/src/Privacy/PersonalDataFields.php
Jobs
ID Job ID Ran Files Coverage
1 33010207558.1 28
92.51
GitHub Action Run
Source Files on build 33010207558