CyclopsMC / IntegratedDynamics / 33005172814

46%

master-1.21-lts: 46%

Pull #1710

github

Fix writer part aspects not activating during network initialization

ba6dd95 moved the aspect (de)activation of
PartStateWriterBase#triggerAspectInfoUpdate inside the
`!isNetworkInitializing` branch, to stop beforeNetworkKill from clearing
the active aspect and persisting that null after a world restart.

That guard however also disabled the other half of the lifecycle:
afterNetworkAlive activates parts via updateActivation without a player,
which makes isNetworkInitializing true. So since then, the active aspect
was never assigned and IAspectWrite#onActivate was never called when a
network is built, which happens on every world load and on every network
rebuild.

Integrated Dynamics' own writers survive this because their active aspect
is restored from NBT, but add-ons rely on onActivate to register their
parts with the network. All Integrated Tunnels importers, exporters and
interfaces therefore stopped working (146 of its game tests failed, and
they all pass again with this change).

The two halves are now separated again:
* Aspects are activated and deactivated at most once, tracked by a
  non-persisted flag, so that killing and reviving a network doesn't
  deactivate an aspect twice or skip its reactivation.
* The active aspect is only forgotten outside of network
  initialization, which is what the original fix needed.

Also adds a game test that configures a writer without a player, which
is the path that add-ons and network initialization use.

2811 of 8932 branches covered (31.47%)

Branch coverage included in aggregate %.

12317 of 24282 relevant lines covered (50.72%)

2.42 hits per line