decentraland / builder / 33000209744

54%

master: 54%

Pull #3469

github

chore: drop the @dcl/hooks override, which decentraland-ui2 3.22.1 retires

The override existed because @dcl/hooks declared
`decentraland-crypto-fetch ^2.0.1` as a peer and arrived transitively
through decentraland-ui2, so npm could satisfy neither range once this
app moved to the 3.x signer and every install failed with ERESOLVE.

Both ends of that are now fixed upstream. hooks 2.0.0 widened its peer to
`>=2.0.0`, and decentraland-ui2 3.22.1 widened the range it accepts to
`^1.2.1 || ^2.0.0` -- without which hooks 2 was unreachable from here, no
matter what this manifest declared. Taking 3.22.1 lets npm resolve hooks
2.0.0 and the override has nothing left to do.

Verified by removing it: `npm ci` passes and the tree holds exactly one
decentraland-crypto-fetch, at 3.0.0, with hooks resolved to 2.0.0.

The lockfile needed the stale `@dcl/hooks` entry dropped before npm would
re-resolve it. `^1.2.1 || ^2.0.0` still admits the 1.6.0 the lockfile
recorded, so npm kept it and the ERESOLVE survived the ui2 bump -- the
range was already right and the pin was what held it back. Worth knowing
for the other consumers of this chain: widening a range does not by
itself move a dependency a lockfile has already pinned.

No crypto-fetch or hooks entries remain in `overrides`. The ones left are
pre-existing and unrelated to this change.

2605 of 6019 branches covered (43.28%)

Branch coverage included in aggregate %.

0 of 3 new or added lines in 1 file covered. (0.0%)

7775 of 13374 relevant lines covered (58.14%)

37.35 hits per line