• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 32999877679
86%

Build:
DEFAULT BRANCH: main
Ran 26 Aug 2026 06:31PM UTC
Jobs 1
Files 257
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

26 Aug 2026 06:28PM UTC coverage: 88.015% (+0.1%) from 87.913%
32999877679

push

github

web-flow
Fix Coloc threshold validation and cancellation registration cleanup (#4872)

Addresses finding L-08 of #4832, and fixes an adjacent defect found
while verifying finding L-05.

**Threshold validation (L-08)**: the `ResumeWriterThreshold <=
PauseWriterThreshold` invariant was enforced only by the
`ResumeWriterThreshold` setter, so it could be bypassed by assignment
order (e.g. `new ColocTransportOptions { PauseWriterThreshold = 2048 }`
against the default resume threshold) or by a `with` expression, and the
invalid pair then failed later inside `PipeOptions` with a raw
`ArgumentOutOfRangeException`. The setters now validate only their own
range and the `ColocTransport` constructor — the single entry point into
the transport — validates the pair, so every assignment order works and
an invalid combination fails immediately with a clear message.

**Registration cleanup**: `TryQueueConnect` discarded the
`CancellationTokenRegistration` returned by `Register`, leaving the
callback (and the captured `TaskCompletionSource` with its pipe reader
result) rooted to the caller's cancellation token for that token's
lifetime, even after a successful connect. The registration now travels
with the queued entry and is disposed when the entry is dequeued by
`AcceptAsync`, drained by `Dispose`, or refused by a full backlog.

Finding L-05 itself — a canceled entry keeps occupying a backlog slot
until an accept dequeues it — is intentionally unchanged.

## What's Changed entry

None — the Coloc transport is mainly used for testing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

15 of 19 new or added lines in 3 files covered. (78.95%)

7 existing lines in 2 files now uncovered.

12404 of 14093 relevant lines covered (88.02%)

3017.12 hits per line

Uncovered Changes

Lines Coverage ∆ File
4
75.0
-25.0% src/IceRpc.Transports.Coloc/ColocTransport.cs

Coverage Regressions

Lines Coverage ∆ File
5
81.72
-1.39% src/IceRpc/ClientConnection.cs
2
90.71
0.63% src/IceRpc/Transports/Slic/Internal/SlicConnection.cs
Jobs
ID Job ID Ran Files Coverage
1 32999877679.1 26 Aug 2026 06:31PM UTC 3841
15.56
GitHub Action Run
Source Files on build 32999877679
  • Tree
  • List 257
  • Changed 206
  • Source Changed 3
  • Coverage Changed 206
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #32999877679
  • ec43b08e on github
  • Prev Build on main (#32981951433)
  • Next Build on main (#33004671341)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc