go-pkgz / auth / 32996973277

87%

master: 87%

Pull #316

github

Drop the parse error rather than wrap it, and pin that no rejection echoes the base

*url.Error prints its URL field verbatim, and the parse branch runs before
every check below it, so a base that is both credentialed and malformed never
reaches the userinfo case and carries its credentials into whatever logs the
constructor failure:

    invalid telegram api base url: parse "https://alice:topsecret@example.com/%zz":
    invalid URL escape "%zz"

A "%" in a proxy password is enough, as is a control character or an unclosed
bracket. Unwrapping to the inner error is no safer: an invalid port quotes it
back as `invalid port ":s3cr3t" after host`, and the IPv6 zone path does the
same. The whole parse boundary is untrusted configuration, so the error says
the base url is not valid and says nothing else.

The test asserted only that an error came back, so reverting every rejection
to interpolate the value again left it green. It now also requires the message
not to contain the base it refused, which covers all seven rejection paths,
and carries the two shapes that reach the parse branch: credentials beside
malformed escaping, and a secret where the port belongs.

115 of 121 new or added lines in 1 file covered. (95.04%)

3301 of 3809 relevant lines covered (86.66%)

9.78 hits per line