raeperd / stepdown / 32992337073

96%

push

github

Fix false positives on interface method calls (#40)

A call through an interface resolves to the interface method, which has no
FuncDecl. When the interface is declared in the same file, the callee passed
the same-file filter but was missing from the declaration map, so its position
lookup returned the zero value. That made calleeLine 0, which is always less
than callerLine, so every such call was reported — with no position attached.

Skip callees that have no declaration in the file. On a subset of the standard
library (net/http, encoding, io) this removes 239 of 2693 diagnostics, all of
them positionless false positives on interfaces such as io.Reader and
http.ResponseWriter, and leaves the genuine violations untouched.

3 of 3 new or added lines in 1 file covered. (100.0%)

168 of 173 relevant lines covered (97.11%)

232.35 hits per line