bedrock-kv / bedrock / 91c9f3602124020affb1fddbfefc869eb82a6c2f

82%

Build Type

push

github

Committed by web-flow

Commit Message

Report the recycler's failures instead of masking them (#216)

Closes bedrock-m7j and bedrock-20c.

Two defects in `SegmentRecycler.Server`, both in how a failure is
*reported*, and both invisible to a test that only walks the happy path.

### 1. Transposed `stop/2` arguments discarded the cause
`Replies.stop/2` is `stop(state, reason)`. `handle_continue` called it
as `stop(reason, :shutdown)`, exiting with `:shutdown` and installing
the real cause as the GenServer's state.

The payoff is **narrower than it first appears**, and the audit is why
this PR says so. The reason does *not* reach Shale's
`classify_resource_error/1` — that only sees the return value of
`start_link/1`, and `init/1` can fail only with
`:path_is_not_a_directory`. An allocation failure happens in the
post-`init` continue, after `proc_lib` has acked `{:ok, pid}`, so it
reaches the log as an async link EXIT that kills it either way.

What the fix genuinely buys: gen_server **suppresses error_info for
`:shutdown`**, so the crash report was silent and the cause was thrown
away. Now `:enospc` or `:eacces` appears in the log, and the `State`
struct survives to `terminate/2`. A log whose disk filled no longer
looks like it shut down politely.

### 2. No refill after an exhausted checkout
`Logic.check_out/2` returns `{:error, :unavailable}` exactly when the
pool is empty — so the one moment a refill was most needed was the one
moment nothing scheduled it, and nothing else drives that continue. Not
reachable today (every path that lowers the pool is immediately followed
by the refill, which stops the process if it cannot restore the floor);
reachable the moment allocation can fail transiently, e.g. a full disk
that later clears.

### Neither fix changes what happens to the owning log
The audit specifically tried to break this and could not. `:shutdown` is
special to *supervisors* and to gen_server's error logging, **not** to
link propagation — only `:normal` is — and Shale does not trap ex... (continued)

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

6806 of 8655 relevant lines covered (78.64%)

1032.04 hits per line