kubeflow / trainer / 32976974935

69%

push

github

feat(runtimes): add deprecation warning for TrainingRuntime (#3966)

* feat(runtime): add deprecation warning for TrainingRuntime

This commit adds deprecation warning support for TrainingRuntime to match
the existing behavior in ClusterTrainingRuntime.

Changes:
- Added deprecation check in TrainingRuntime.ValidateObjects()
- Emits admission warning when runtime has label trainer.kubeflow.org/support=deprecated
- Follows same pattern as ClusterTrainingRuntime implementation

The implementation ensures consistent deprecation warnings across both
runtime types, helping users identify deprecated runtimes early.

Fixes #3965

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* test: add comprehensive tests for TrainingRuntime deprecation warnings

- Add TestTrainingRuntimeValidateCreate to verify deprecation warnings
  when creating TrainingRuntime objects with support=deprecated label
- Add test cases for TrainJob referencing deprecated TrainingRuntime
- Extend TrainingRuntimeValidator.ValidateCreate to emit deprecation
  warnings, matching ClusterTrainingRuntime behavior
- Ensures consistent deprecation warnings across both runtime types

Addresses feedback on #3965

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

---------

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

9 of 22 new or added lines in 2 files covered. (40.91%)

2615 of 3821 relevant lines covered (68.44%)

0.8 hits per line