decentraland / builder / 32976403831

57%

push

github

fix: infinite render loop in the Intercom component (#3482)

analyticsReadyCallback depended on intercomUserData and set a new state
object on every invocation, so each render recreated the callback,
re-ran the effect, and re-registered analytics.ready() — which invokes
the callback again once analytics.js is loaded. The result was a
permanent ~1,300 commits/sec render loop calling Intercom('update') on
every cycle.

Latent since the callback was introduced, it started firing for
everyone once #3475 moved analytics.js behind a first-party proxy that
ad blockers no longer drop.

Fix: stable callback plus a functional update that returns the same
reference when the anonymous id hasn't changed, so React bails out.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2598 of 5991 branches covered (43.37%)

Branch coverage included in aggregate %.

7747 of 13282 relevant lines covered (58.33%)

37.59 hits per line