MapColonies / shigola / e17ffb2d8

48%

master: 48%

Pull #7

github

test(ci): pin the environment in the baseline gates test

CI failed on TestWriteBaselineKeepsTheRecordedFloor, and the test was the thing
that was wrong.

Since the gates are read off the environment, the test's behaviour depended on
whether the host had any RUN_*_TESTS set. Locally none are, so the recorded
gates were kept and it passed; in CI four are, so the environment correctly
overrode them and it failed. A test that reads ambient environment asserts
something different on every machine.

It now pins the gate variables with t.Setenv and asserts the contract in both
directions: the floor is never lowered by a leaner run, the recorded gates are
kept only when the environment says nothing, and an environment with different
suites enabled overrides them -- because the gates are provenance for the
numbers being written, not a property inherited from the file being replaced.

Also corrects a claim this branch had put in CONTRIBUTING and in the workflow
comment. It said RUN_S3_TESTS and RUN_HANA_TESTS were excluded because no
credentials are configured; the CI log for this PR shows both really do run
there, covering cache/s3 at 65.6% and provider/hana at 67.7% against the 19.53%
and 3.77% the baseline records. The reason to exclude them is that a contributor
cannot provision either one locally, not that they do not work -- and the
consequence, that CI measures well above the recorded total, is now stated
rather than implied.

227 of 292 new or added lines in 3 files covered. (77.74%)

9823 of 20391 relevant lines covered (48.17%)

203.78 hits per line