carlobeltrame / ecamp3 / 32953182453

35%

devel: 43%

push

github

Improvements after core team discussion

- [x] On desktop, hide activity comments, and show a small notice instead, informing that there may be comments in the individual activities as well
- [x] On mobile, comments panel is fullscreen
- [x] In the panel, comments are ordered by createTime ASC, like a chat, not grouped into buckets (until we implement anchoring to parts of an activity)
- [x] When creating a comment, after reloading the list of comments, scroll to the bottom of the comments list, like a chat interface
- [x] On mobile, clicking a comment badge on a dashboard row should open the panel filtered to that activity (but not navigate)
- [x] On mobile, navigating while the comments panel is open (e.g. clicking on a schedule entry link) should close the comments panel
- [x] On desktop, clicking a comment badge on a dashboard row should navigate to the activity and open the panel
- [x] Posting a new comment should scroll the panel to the bottom, so the new comment is immediately visible
- [x] The focusing and flashing logic can be removed, and the program order logic and the bucket grouping as well

Refs https://github.com/ecamp/ecamp3/issues/828#issuecomment-5227232166
Refs https://github.com/ecamp/ecamp3/issues/828#issuecomment-5258388327

837 of 4619 branches covered (18.12%)

Branch coverage included in aggregate %.

34 of 36 new or added lines in 7 files covered. (94.44%)

4615 of 10781 relevant lines covered (42.81%)

63.95 hits per line