FlexMeasures / flexmeasures / 32950918913
84%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 176
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.118%. Remained the same
32950918913

push

github

web-flow 
Strip symbol tables from the compiled extensions in the Docker image (#2439)

* fix: shrink docker image by excluding dev deps and pruning sktime's stray docs/examples

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* docs: fill in the PR number in the changelog entry

Context:
- Review on #2438: the entry still carried the XXXX placeholder, in the label and the URL

Change:
- Pointed both at PR #2438

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docker: strip symbol tables from the compiled extensions

Context:
- Most wheels ship their compiled extensions unstripped. The symbol tables and debug
  info they carry are never used at runtime, and openturns alone accounts for over a
  fifth of the weight

Change:
- Strip the shared objects in the builder stage, so only the stripped virtual
  environment is copied into the runtime image and no layer keeps the fat copy
- --strip-unneeded retains everything dynamic linking needs, so the extensions
  stay loadable

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: widen the Docker image entry to cover the stripping

Context:
- Both PRs shrink the image through the builder stage, so one entry reads better
  than two

Change:
- Expanded the entry #2438 introduced to mention the symbol stripping, and
  appended PR #2439 to its reference list

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docker: fail the build when strip is missing, instead of silently skipping

Context:
- Review: the trailing '|| true' also swallows 'strip: not found', which would
  turn this step into a no-op and let the image quietly grow back by ~130 MB
  with nothing failing. binutils arrives via gcc today, but that is incidental

Change:
- Check for strip up front and exit 1 with a message naming binutils
- Kept '|| true' on the find, which is there to tolerate individual files that
  strip cannot handle
- Also reworded the size note, which read ungrammatically

Signed-off-by: F.N. Claessen <felix@seita... (continued)

17410 of 20697 relevant lines covered (84.12%)

0.84 hits per line

Jobs
ID Job ID Ran Files Coverage
1 32950918913.1 176
84.12
 GitHub Action Run
Source Files on build 32950918913