Kikobeats / router-http / 32935253742

99%

push

github

fix: do not treat query slashes as the path of an absolute-form target (#39)

* fix: do not treat query slashes as the path of an absolute-form target

find-my-way 9.9.0 stopped using /^https?:\/\/.*?\// because a request
like GET http://host?next=/admin was rewritten to /admin. router-http
still applied that regex before find() and mount matching, so the same
target selected the admin route. Parse the authority separately so an
empty path stays / and invalid targets reach onBadUrl.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* test: drop the absolute-form fragment case Node's parser rejects

GET http://host#next=/admin is a clientError (Unexpected char in url)
before the router runs. Cover that spelling in-process instead, and
keep the HTTP onBadUrl cases Node actually delivers.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* test: keep query-slash off /admin mounts

The route test still passed if .use('/admin') ran. Assert the
query too so a rewrite to / that drops it fails.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor: fold query-slash mount into one test

authorize on /admin is the canary; a second server restated the
same table. Leave the find-my-way copy untouched so bumps stay a
diff.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>

207 of 212 branches covered (97.64%)

Branch coverage included in aggregate %.

48 of 50 new or added lines in 1 file covered. (96.0%)

576 of 580 relevant lines covered (99.31%)

2686.66 hits per line