tarantool / tarantool / 32932739057

88%

Build Type

push

github

Committed by ImeevMA

Commit Message

sql: calculate the `JOIN` type using parser rules

This patch creates rules for evaluating the `JOIN` type instead of using
the special function defined in `select.c`.

This simplifies the evaluation. It also changes the error description
when the `JOIN` type evaluates to both `INNER` and `OUTER`.

Some errors related to `JOIN` evaluation are now reduced to syntax
errors.

Part of #5485

@TarantoolBot document
Title: Supported `JOIN` type keyword combinations

In Tarantool SQL, a `JOIN` type is defined by combining up to three
special keywords (`CROSS`, `INNER`, `LEFT`, `NATURAL`, `OUTER`, `RIGHT`)
before the `JOIN` operator:
1. No keyword - `INNER JOIN`.
2. One keyword:
  - `CROSS` -> `INNER JOIN` + `CROSS JOIN`;
  - `INNER` -> `INNER JOIN`;
  - `LEFT` -> `LEFT JOIN` + `OUTER JOIN`;
  - `NATURAL` -> `NATURAL JOIN`;
  - `OUTER` -> `OUTER JOIN`;
  - `RIGHT` -> `RIGHT JOIN` + `OUTER JOIN`;
3. Two and three keywords - union of types from previous rule.

The `JOIN` type cannot be both `INNER` and `OUTER`. Also, `OUTER` other
than `LEFT`/`LEFT OUTER` is not supported (for example, `RIGHT JOIN`,
`RIGHT OUTER JOIN`, plain `OUTER JOIN`, or `LEFT RIGHT JOIN`).

Coverage Stats

72309 of 121422 branches covered (59.55%)

19 of 19 new or added lines in 2 files covered. (100.0%)

147 existing lines in 20 files now uncovered.

108211 of 123173 relevant lines covered (87.85%)

1387314.85 hits per line