dblock / hashie / 32909826209

98%

master: 98%

push

github

Fix Coercion#coerce_value not triggering for nested Hashes in a Mash

Hashie::Mash's initializer and writers recursively convert nested Hash
values into instances of self.class before Hashie::Extensions::Coercion
gets a chance to inspect them. By the time coerce_value's is_a? check
runs, the value is already an instance of the Mash subclass (which
is-a Hash), so any coerce_value Hash, SomeOtherMash rule never
triggers.

Fix by overriding Coercion::InstanceMethods#convert_value to check for
a matching value coercion first, before falling through to Mash's own
Hash-to-Mash conversion via super. This runs earlier in the ancestor
chain since Coercion is mixed in before Mash defines convert_value.

Closes #265

22 of 22 new or added lines in 2 files covered. (100.0%)

4209 of 4278 relevant lines covered (98.39%)

92.3 hits per line