• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In
Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch.
This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

    • Learn more: For more information on this, see Tracking coverage changes for pull request builds.
    • Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
    • Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.
New Repo Setting:
INCLUDE COVERAGE % WITH WARNINGS ABOUT DRIFTED BUILDS?

Enabling this setting will include a (potentially inaccurate) coverage % with warning messages in status updates for drifted builds.

Adjust setting

kubeflow / trainer / 32908514457
69%
master: 68%

Build:
Build:
LAST BUILD BRANCH: feat/validate-runtime-patches-volumes
DEFAULT BRANCH: master
Ran 25 Aug 2026 11:01PM UTC
Jobs 1
Files 43
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Aug 2026 10:56PM UTC coverage: 68.807% (+0.3%) from 68.543%
32908514457

Pull #3961

github

Prat260104
refactor: validate RuntimePatches after merge, remove duplicate checks

Changes based on mentor feedback:

Per-patch validation (ensure resources exist in template):
- Validate ReplicatedJob exists in runtime template
- Validate Container exists in runtime template
- Validate InitContainer exists in runtime template
- Validate no envs for reserved containers

Merged validation (after all patches applied):
- VolumeMount references existing volumes (after merge)
- VolumeMount mountPath is not empty
- Toleration operator is valid (Equal/Exists)
- Toleration effect is valid (NoSchedule/PreferNoSchedule/NoExecute)
- Toleration with Equal operator has value when key specified

Removed validations (handled by Kubernetes):
- Duplicate volume names (K8s listType=map prevents this)
- Duplicate volumeMount names (K8s listType=map prevents this)
- Duplicate tolerations (allowed per mentor feedback)
- Duplicate mountPaths (K8s handles this)
- Empty volume names (K8s validates this)

Tests:
- Updated 5 tests to reflect merged state in info.TemplateSpec.ObjApply
- Removed 3 tests for validations no longer performed
- All tests pass

Addresses feedback on #3893

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>
Pull Request #3961: feat(framework): validate Volumes, VolumeMounts, and Tolerations in RuntimePatches

56 of 62 new or added lines in 1 file covered. (90.32%)

3 existing lines in 1 file now uncovered.

2658 of 3863 relevant lines covered (68.81%)

0.8 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
78.21
2.22% pkg/runtime/framework/plugins/jobset/jobset.go

Coverage Regressions

Lines Coverage ∆ File
3
74.07
-11.11% pkg/runtime/core/core.go
Jobs
ID Job ID Ran Files Coverage
1 32908514457.1 25 Aug 2026 11:01PM UTC 43
68.81
GitHub Action Run
Source Files on build 32908514457
  • Tree
  • List 43
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #3961
  • PR Base - master (#32447518121)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc