bleedingdeacons / monitor / 32908539371
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 13
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 95.953%. Remained the same
32908539371

push

github

web-flow 
fix(ci): gate the version bump on the build, tests and Semgrep (#25)

version.yml triggered on `push` to main with no `needs:` and no conditions, so
a version was cut whether or not anything had passed. A red build, a failing
test or a blocking Semgrep finding all still produced a version.

The bump job moves into ci.yml with `needs: [build, test, semgrep]`, which is
the same shape the PHP plugin suite uses (`release: needs: ci`). Moving it
rather than switching version.yml to `workflow_run` is deliberate: the bump
range is computed from `github.event.before`, which only exists on a push
event, and a workflow_run trigger would have meant rewriting that load-bearing
logic to chase head SHAs.

Two things had to move with it.

The workflow concurrency cancelled superseded runs on every ref, including
main. With the bump living here that would silently drop a version, which is
exactly what version.yml's own comment warned against. Pull request runs still
share a group and cancel; runs on main now key on github.run_id so they cancel
nothing. Ported from the plugin suite.

And permissions: the workflow default is contents: read, so the bump job asks
for write on its own rather than widening the whole file.

Also corrects three comments left stale by the move - in dependabot.yml, in
bump-version.sh, and the note in this file's own Semgrep job, which was written
this afternoon and claimed the bump was ungated. It no longer is.

901 of 939 relevant lines covered (95.95%)

15.31 hits per line

Jobs
ID Job ID Ran Files Coverage
1 32908539371.1 13
95.95
GitHub Action Run
Source Files on build 32908539371