dblock / hashie / 32904798897

100%

master: 98%

push

github

Push test coverage to 100%

Add tests to cover previously untested branches across the codebase
(Clash, Dash, Mash, Coercion, IndifferentAccess, Rash, Utils,
RubyVersion, and various support/spec files).

Fixes a real bug found along the way in
Hashie::Extensions::Mash::DefineAccessors: define_writer,
define_predicate, define_initializing_reader, and
define_underbang_reader passed a bare Kernel#proc (which requires an
actual block context) as &proc to self.[], causing an ArgumentError
whenever the key already matches the generated method name. Hash#[]
doesn't accept blocks, so the pointless block-forwarding is removed.

Also fixes a spec bug where stringify_keys_spec.rb and
symbolize_keys_spec.rb both defined a global 'def invoke(method)'
helper with the same name, silently shadowing each other.

Removes unreachable legacy Ruby-version dead code now that the gem
requires Ruby >= 2.7 (Psych >= 3.1, Fixnum/Bignum unification, and
pre-splat-args deep_merge/deep_update are no longer reachable), and
removes an always-dead 'when self.class' branch in
StringifyKeys/SymbolizeKeys.

Removes :nocov: markers from spec files in favor of simplifying dead
test fixture code, since :nocov: should only be needed in lib/.

Excludes spec/support/ from SimpleCov since it contains test helpers,
not application code, and doesn't need its own test coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

204 of 204 new or added lines in 18 files covered. (100.0%)

4344 of 4344 relevant lines covered (100.0%)

91.81 hits per line