GrottoCenter / grottocenter-api / 32897665274

91%

Build Type

push

github

Committed by ClemRz

Commit Message

fix(document): address code review findings

- P1: add DocumentService.clearParentIfTypeDisallows() helper and call
  it in update-with-new-entities.js so both update paths enforce the
  same type-vs-parent policy (stale parent cleared on type change)
- P2: migration now uses DROP CONSTRAINT IF EXISTS + ADD NOT VALID +
  VALIDATE CONSTRAINT for idempotency and safe application over
  pre-existing corrupt rows
- P2: guard checkParentCycle() call sites with Number.isFinite() to
  prevent a NaN false-negative when ids are non-numeric
- P3: TYPES_REQUIRING_PARENT is now an alias of TYPES_ALLOWING_PARENT
  with a comment explaining the equivalence
- P3: rename misleading test title to reflect actual assertion

Coverage Stats

5197 of 6242 branches covered (83.26%)

Branch coverage included in aggregate %.

30 of 35 new or added lines in 5 files covered. (85.71%)

17 existing lines in 2 files now uncovered.

9565 of 10662 relevant lines covered (89.71%)

141.04 hits per line