MapColonies / shigola / ffe9d95b2

48%

master: 48%

Build Type

Pull #6

github

Committed by NivGreenstein

Commit Message

feat(server): remove the embedded viewer

Shigola serves tiles, not a map. The viewer route, the embedded UI assets, the
build tags that excluded them, and the viewer half of the observability
interface all go.

This is sequenced first among the surface removals because the viewer consumes
both the capabilities endpoints and the native /maps/... routes. Removing those
first would have left it broken in passing rather than removed on purpose.

What goes with it:

- The /viewer routes, and setupViewer along with the noViewer build tag that
  chose between the two implementations. There is no tag left to set: passing
  -tags noViewer now builds exactly the same binary.
- ui/, the Vue application and its go:embed wrapper, and the go:generate
  directive that shelled out to npm to build it. The only go:generate left in
  the tree is the build-tag one, which needs nothing but Go.
- The build_ui job in the release workflow, the ui artifact it published, the
  seven jobs that waited on it, and the `ui` input on shigola-setup-env that
  downloaded it. The ticket named only the test job's step; leaving the release
  half would have had every build job waiting on an artifact no job produces.
- ViewerObserver, InstrumentViewerHandler, and the shigola_viewer metric family.

Dropping that `ui` input emptied five `with:` blocks. A bare `with:` parses as
null, which GitHub's workflow schema rejects outright, and on_pr_push.yml does
not exercise the release workflow -- so PR CI would have stayed green and the
whole release would have failed to parse the next time it ran. Those `with:`
lines are removed rather than left empty.

The docs simply stop mentioning a viewer, rather than announcing that one was
removed. There is no stable release to upgrade from, so there is nobody for a
migration note to address; documenting an absence would only raise a question
the reader did not have.

The generated build-tag files are regenerated rather than hand-edited, which is
also wh... (continued)

Pull Request Pull Request #6: feat(server): remove the embedded viewer

Coverage Stats

3 of 9 new or added lines in 3 files covered. (33.33%)

1 existing line in 1 file now uncovered.

9596 of 20099 relevant lines covered (47.74%)

206.57 hits per line