supabase / supabase-swift / 32873232778

87%

Build Type

push

github

Committed by web-flow

Commit Message

fix(postgrest): let Update change a primary key column (#1280)

* fix(postgrest): let Update change a primary key column

`Update` dropped primary-key columns along with `Insert`, so a key could
never be changed through the typed API. Renaming a natural key — the
`slug` in a table keyed on `(tenant_id, slug)` — meant dropping to the
legacy builder.

The exclusion protected nothing. `update(_:)` returns a mutation the
caller filters separately, so targeting and payload are independent
concerns; the doc on `update(_:)` already warns that with no filter it
touches every row. Holding the key back did not keep a write from
rewriting identity, it only removed the ability to do so deliberately.

`Update` now carries every column, all optional as before, so a caller
that does not name the key is unaffected and the column stays out of the
request body.

That leaves `isPrimaryKey` used for exactly one thing — making the key
optional rather than required in `Insert` — which is what the marker
should have meant all along.

Fixes SDK-1607

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(postgrest): give @PrimaryKey a job — report the key columns

Review of #1280, finding 1. The review found `isPrimaryKey` down to a single
use, sitting in an `||` next to `hasDefault`, so `@PrimaryKey var id: Int` and
`@Default var id: Int` expanded identically. Rebasing onto the revised #1278 —
which dropped `|| isPrimaryKey` from the `Insert` rule — removed that use too.
Combined with this PR taking the key out of the `Update` filter, the marker had
**zero** behavioural effect: writing it or omitting it expanded byte-for-byte
the same.

Verified after the rebase: `grep -n isPrimaryKey Sources/` returns only the
declaration and the attribute read. Nothing consumed it.

The review named two ways out. The first — differentiate it from `@Default` —
already happened on #1278, and it is what emptied the marker rather than
filling it. The second was to give `@PrimaryKey` something... (continued)

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

9199 of 10567 relevant lines covered (87.05%)

1016260.92 hits per line