decentraland / notifications-workers / 32861356087

80%

main: 80%

Pull #185

github

refactor(auth): scope the legacy payload fallback to the read route

The declared key list was on the single shared middleware instance, so
it relaxed every signed route in the service. Only one of them needs it.

Checking what each caller actually sends: decentraland-dapps adds
`notificationIds` to the metadata on `PUT /notifications/read` and sends
an all-lowercase `{ signer, intent }` everywhere else, which folds to
itself; godot-explorer signs the request *body* as its metadata, which
is `{"notificationIds":[…]}` on that route and `{}` on its only other
call. unity-explorer and `sites` sign `{}` throughout.

So the read route is the only one where the two payload formats disagree,
and the only one that would have 401ed.

A second instance carries the fallback and serves that route alone.
Everything else stays on the current format only, which is what stops the
relaxation from becoming service-wide by default and makes moving a route
onto it a deliberate edit.

A test pins the boundary rather than leaving it to the wiring: the same
folded payload that the read route now accepts is still a 401 on
`GET /notifications`.

239 of 377 branches covered (63.4%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

881 of 1016 relevant lines covered (86.71%)

20.73 hits per line