urwid / urwid / 32854982857

94%

Build Type

push

travis-pro

Committed by web-flow

Commit Message

Fix sizing related issues (#1250)

## Fixes
- **`Overlay`: oversized `width=PACK` no longer raises `WidgetError`.**
  `render()` passed the negative `left`/`right` padding to `CanvasOverlay` as a *position*,
  shifting the already-trimmed top canvas off the left edge
  and producing a canvas wider than the requested size.
  The padding itself is left untouched
  (negative values are the correct coordinate model for clipped content,
  and `mouse_event`/`get_cursor_coords` rely on it);
  only the overlay position is clamped.
- **`Overlay`: `PACK` height is measured at the width the top widget actually gets**
  (`maxcol - left - right`) instead of the overlay's full width.
  Fixes wrong vertical centring and dead mouse clicks below wrapped text.
  Since `render`, `keypress`, `mouse_event` and `get_cursor_coords`
  all route through `calculate_padding_filler`,
  all four become consistent, and it now agrees with `Overlay.rows()`.
  Fixes #471.
- **`Canvas.set_pop_up`: enforces its documented preconditions.**
  `left`/`top` `>= 0` and `overlay_width`/`overlay_height` `> 0`
  were documented but unchecked,
  so bad values either silently mis-placed the pop-up
  or surfaced later as a bare `ValueError: 0`.
  Now raises `CanvasError` with a clear message.
- **`Filler.sizing()`: warns when a `PACK` height is paired with a non-FLOW body.**
  Such a `Filler` declared `{BOX, FLOW}`
  but failed at *every* size with an opaque
  `AttributeError: '…' object has no attribute 'rows'`.
  Follows the existing `Padding.sizing()` pattern
  (warn via the new `FillerWarning`, returned set unchanged).
  Relates to #247.
- **`PopUpLauncher.create_pop_up`: documents that the pop-up must accept a box size**,
  since `PopUpTarget` always overlays with `GIVEN`/`GIVEN`.
  Previously a flow pop-up failed with an unexplained
  `ValueError: too many values to unpack`.

Coverage Stats

3081 of 4930 branches covered (62.49%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 3 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

8563 of 11611 relevant lines covered (73.75%)

2.21 hits per line