cybertec-postgresql / pg_timetable / 32852812155

89%

push

github

[!] add Windows service support (#825)

* Feat: Windows service support

- Add switch options --service  to register/unregister/start/stop windows service
- Add instructions in installation.md for using these
- Add workflow test to confirm windows still builds on any change

* prevent dropped stop and data race on Windows service shutdown

The Windows service handler runs on a goroutine started from `init()`,
before `main()` assigns the context cancel function. A stop request
arriving in that startup window was silently dropped (service reported
stopped while the scheduler kept running), and `cancelFn` was
read/written across goroutines without synchronization (data race
under -race).

Make `cancelFn` an `atomic.Pointer[context.CancelFunc]` and add
a `sync.Once`-closed cancelReady channel. On stop, `cancelApplication()`
waits for readiness (bounded by `serviceStopTimeout`) while emitting
`StopPending` heartbeats, then cancels once the target is available.
It also re-checks `getCancelFn()` each iteration so an already-set
cancel fires immediately.

Add `TestCancelApplicationWaitsForReadiness` plus cross-platform
cancel-state test helpers; run service tests with a bounded timeout.

* make linter happy

* move windows-specific parts out of common `main_test.go`

* add notify package to Windows tests

* increase service test coverage

* fix bug when a service is installed but not running

* add start/restart/stop workflow to tests

* Removed `install` from the `TestHandleServiceCommandDispatch`

* add `TestServiceRealStartStop` and fix `winServiceRunner.Execute`

* Make the service process terminate itself once the SCM stops it

* Add `TestConfigServiceSkipsDaemonRequirements`

---------

Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>

239 of 300 new or added lines in 6 files covered. (79.67%)

2505 of 2823 relevant lines covered (88.74%)

1.03 hits per line