hyperledger / fabric-x-common / 32851836683

82%

Build Type

push

github

Committed by web-flow

Commit Message

Upgrade to Go 1.27.0 (#162)

#### Type of change

- Dependency update
- Improvement (improvement to code, performance, etc)

#### Description

- Bump the `go` directive to 1.27.0 and apply `go fix ./...`:
`reflect.Pointer`,
`reflect.TypeFor[T]()`, `reflect.Type.Fields()`, `strings.SplitSeq`,
`slices.Contains` /
`slices.Backward`, `maps.Copy`, `atomic.Int32` fields,
`sync.WaitGroup.Go`, range-over-int,
`any` over `interface{}`, and promoted embedded fields in composite
literals.
- Move golangci-lint to v2.13.1 and replace the deprecated gofumpt
`extra-rules` option with
  `extra.group-params`.
- Migrate mockery to v3.7.4: the seven `//go:generate mockery`
directives in
`core/policy/application.go` collapse into one bare directive plus a new
`.mockery.yml`, and
  `core/policy/mocks/` is regenerated with v3's testify template.
- `golang.org/x/crypto` becomes indirect — its only use was `sha3`, now
stdlib `crypto/sha3`.
- Restructure `computeGroupUpdate` in
`tools/configtxlator/update/update.go` to assign the
read/write sets before returning them, so that `gofmt` and `goimports`
agree on the file.
- Address the pre-existing lint findings the rewritten lines surfaced:
one checked
`mspId.(*identity)` assertion in `msp/identities.go` in place of four
unchecked ones, blanked
unused parameters, two doc comments, and two scoped `//nolint:gocognit`
on ported `viperutil`
  functions.
- Drop `protolator`'s `stringInSlice` helper for `slices.Contains` at
its nine call sites.
- Update `AGENTS.md` and the `development` / `tests` skills for Go 1.27
and the mockery change.

#### Additional details (Optional)

`go fix` is not idempotent under 1.27 — each pass can unlock further
rewrites — so it was run to
convergence.

Verified: `make lint` (asn1 + proto + golangci + license) reports 0
issues, `go test -race ./...`
passes 72 packages, `make tools` builds all three CLIs, and `make proto`
/ `make mocks` produce no
drift.

#### Related issues

- resolves #161

Signed-off-b... (continued)

Coverage Stats

164 of 171 new or added lines in 19 files covered. (95.91%)

4 existing lines in 4 files now uncovered.

13284 of 16281 relevant lines covered (81.59%)

0.82 hits per line