fluentassertions / fluentassertions / 32848243788

98%

push

github

Migrate xunit v3 test projects off the VSTest pipeline

xunit.v3 4.0.0 (the version dependabot PR #3312 bumps to) pulls in a
newer Microsoft.Testing.Platform.MSBuild, which refuses to run through
the classic VSTest pipeline (dotnet test --collect "XPlat Code
Coverage") on the .NET 10 SDK: "Testing with VSTest target is no
longer supported by Microsoft.Testing.Platform on .NET 10 SDK and
later."

Approval.Tests, XUnit3.Specs and XUnit3Core.Specs now run through the
native Test/InvokeTestingPlatform MSBuild targets instead of `dotnet
test`, passing MTP-native arguments via the
TestingPlatformCommandLineArguments property. Unlike TUnit, which
implements the generic Microsoft.Testing.Platform CLI directly, xunit
v3's in-process console runner only understands its own command line
when launched directly (e.g. via dotnet run), so it must go through
this property instead of process arguments.

The xunit.runner.visualstudio (VSTest adapter) and coverlet.collector
references are no longer needed for these projects.

XUnit3.Specs and XUnit3Core.Specs intentionally don't collect code
coverage. Microsoft.Testing.Extensions.CodeCoverage and coverlet (used
by every VSTest-driven project here) disagree on what counts as a
"coverable" line/method for the exact same FluentAssertions build, so
mixing their cobertura output in the same ReportGenerator merge
inflates the denominator and craters the reported percentage without
any real coverage having been lost. TUnit.Specs has the same
"one MTP-native smoke test" shape and already sidesteps this by never
producing a cobertura report; these two follow suit until the two
coverage engines can be reconciled.

Verified locally end-to-end with the actual Fallout build driver
(ApiChecks, VSTestFrameworks, TestingPlatformFrameworks,
MTPTestFrameworks and CodeCoverage all pass, and line coverage matches
main at ~98%).

4151 of 4394 branches covered (94.47%)

Branch coverage included in aggregate %.

13343 of 13530 relevant lines covered (98.62%)

69471.24 hits per line