• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Chaguar / committer / 32845475620
91%

Build:
DEFAULT BRANCH: main
Ran 25 Aug 2026 12:07PM UTC
Jobs 3
Files 132
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Aug 2026 12:02PM UTC coverage: 90.392% (+0.3%) from 90.108%
32845475620

push

github

web-flow
[test] Make container teardown tolerate an already-exited container (#761)

#### Type of change

- Bug fix
- Test update

#### Description

- `utils/testdb`: `StopContainer` no longer fails when the container has
already exited or no longer
exists, and `StopAndRemoveContainer` tolerates one that is already gone
— making the pair idempotent
for a container in any state, alongside the guard it already had for one
that was never created. The
typed `errors.As` checks mirror the `*docker.ContainerAlreadyRunning`
handling in `start`.
- Add `TestStopAndRemoveContainerIsIdempotent`: it starts a real
container, stops it out of band the way
  a self-exiting node would, then tears it down twice.

#### Additional details (Optional)

The graceful stop is kept rather than relying on `RemoveContainer`'s
`Force: true`, because
`StopAndRemoveContainer` is also the mid-test action that kills a node
(`DBClusterController.StopAndRemoveSingleNodeByIndex`): force removal
would replace SIGTERM-with-grace by
an immediate SIGKILL and change what the resiliency scenarios exercise.

To see the effect, revert `utils/testdb/container.go` and keep the test:
it fails at `container.go:449`,
the line that failed in CI. The test reaps its container directly
through the docker client in
`t.Cleanup`, not through the method under test, so a regression cannot
leak it.

#### Related issues

- resolves #760

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

9229 of 10210 relevant lines covered (90.39%)

10908.7 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
79.57
-2.15% service/query/query.go
2
91.08
-0.62% mock/orderer.go
1
97.12
2.88% mock/coordinator.go
1
78.09
1.63% service/sidecar/sidecar.go
1
93.9
-1.22% loadgen/adapters/common.go
Jobs
ID Job ID Ran Files Coverage
1 core-db-test - 32845475620.1 25 Aug 2026 12:07PM UTC 101
47.87
GitHub Action Run
2 unit-test - 32845475620.2 25 Aug 2026 12:09PM UTC 94
84.67
GitHub Action Run
3 db-test - 32845475620.3 25 Aug 2026 12:07PM UTC 132
78.11
GitHub Action Run
Source Files on build 32845475620
  • Tree
  • List 132
  • Changed 16
  • Source Changed 0
  • Coverage Changed 16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 9f5f0007 on github
  • Prev Build on main (#32845340328)
  • Next Build on main (#32850865063)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc