gephi / graphstore / #574

91%

push

Close graph-lock gaps in GraphModel.Serialization (#289)

* Hold the graph read lock for the entire duration of serializeGraphStore

Previously the only locking came incidentally from NodeStore/EdgeStore
iterators, which release the lock between the node and edge loops and
leave the configuration/columns/time store/views sections unprotected,
so a serialized graph could observe a torn state under concurrent
mutation.

* Hold the graph write lock for the entire duration of deserializeGraphStore

deserializeNode/deserializeEdge write directly into NodeStore/EdgeStore,
bypassing GraphStore's own auto-locked addNode()/addEdge(), so
deserialization had no lock coverage at all and could race with a
concurrent reader on the same graph model.

* Cleanup

44 of 45 new or added lines in 1 file covered. (97.78%)

11789 of 12925 relevant lines covered (91.21%)

0.91 hits per line