go-pkgz / auth / 32834275027

86%

master: 87%

Pull #318

github

Assert the identicon depends on the user, and drop what #317 now carries

Two follow-ups from #317's review.

The geometry assertions accept a generator that ignores its user argument: one
fixed image decodes, is png, is 300x300 and is not uniform for every caller. The
byte counts they replaced rejected that by accident, since different users gave
different lengths, so the swap lost a mutation it had been catching.
TestGenerateAvatar_DiffersPerUser compares pixels for two user ids instead of
encoded size, which is the thing that moved with the Go release, and also
asserts the same user twice is stable, since an identicon that churns per login
is the other way this can go wrong. Mutation-checked: making Draw ignore its
argument fails this test and nothing else, which is the point.

The identicon hunks in provider/dev_provider_test.go and
provider/custom_server_test.go are dropped here, since #317 landed the superset
with the uniformImage assertion this branch's copy lacked.

46 of 46 new or added lines in 2 files covered. (100.0%)

3236 of 3755 relevant lines covered (86.18%)

9.68 hits per line