PHPOffice / PHPPresentation / 32826131615

94%

push

github

ODPresentation Reader : Read back the alignment of a paragraph (#927)

* ODPresentation Reader : Read back the alignment of a paragraph

`loadStyle()` parses `style:paragraph-properties` into an `Alignment` and files it
in `arrayStyles` under `alignment`. In the whole of the Reader that key has one
reader, `readListItem()`, and the object it reads there is a different one, built
from `text:list-style` for the indent and the margins. So for an ordinary
paragraph the alignment was parsed and then dropped: `readParagraph()` takes the
spacing and the line spacing out of the same style entry and walks past it.

Three things had to be right for the round trip, and two of them were not:

`fo:text-align` was stored raw. `setHorizontal('left')` puts the ODF spelling in a
model whose constants are `l`, `r`, `ctr` and `just`, so even where the value was
used it was not one the writer could match. It is mapped now, over the four
alignments this library writes.

`style:writing-mode` was read as left to right in both arms of its switch --
`lr-tb`/`tb-lr`/`lr` and `rl-tb`/`tb-rl`/`rl` alike both called
`setIsRTL(false)`. The second is a typo for `true`, there since be48bb383 added
right-to-left support in 2021. On its own it changes nothing observable, which is
why it survived: without the paragraph reading the alignment at all, the value it
corrects was never asked for.

And `readParagraph()` now applies the alignment it already had in hand.

Measured on a shape written by this library: `style:writing-mode="rl-tb"` went out
and `isRTL()` came back `false`. With the three together, all four horizontal
alignments and the direction survive a save and a load.

* Declare the data provider the way PHPUnit 9 reads it

PHP 7.4 and 8.0 run PHPUnit 9.6, which does not read the `#[DataProvider]`
attribute. Every other provider in the suite carries both spellings; this one
carried only the attribute, so on those two versions the test was called with no
argument at all.

16 of 16 new or added lines in 1 file covered. (100.0%)

10358 of 11199 relevant lines covered (92.49%)

52.51 hits per line