Qiskit / qiskit / 32822278047

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Revert "QPY 18: give Duration and Big integers their own type keys (#16802)" (#16821)

In the recently merged #16802 the QPY format was updated to add new type
keys for fields in QPY. The intent was that there was some potential key
character overlap between various parts and by creating distinct values
between them. However, this was misreading how the QPY should
be used. The type keys in QPY are a common design pattern used in
several places in the format, but were never intended to be in a shared
namespace; the keys were supposed to be used for type discrimination in
the local evaluation of different instructions. The tension cauing the
desire for this was the Rust implementation of QPY attempting to globally
define all the type keys in a shared enum which is at odds with the
intent of the format specification. The change made in #16802 attempting
to update the format makes it more confused and adds a lot of extra
complexity to the format. Instead this situation should be addressed by
updating the rust QPY implementation to move away from the global type
key enum and split out the typing to be scoped to the context they're
being used (i.e. interpret the duration only when evaluating a delay
instruction).

This reverts commit 5cdc8cb99.

Coverage Stats

8 of 29 new or added lines in 2 files covered. (27.59%)

31 existing lines in 4 files now uncovered.

114141 of 130093 relevant lines covered (87.74%)

991518.35 hits per line