emqx / esockd / 588

67%

master: 67%

Pull #227

github

fix: address PR review comments

- esockd_connection_sup: peername failures are returned tagged as
  {error, {peername, Reason}} so callers can tell 'peer already gone'
  apart from errors returned by the connection MFA itself
- esockd_acceptor: handle 'ignore' explicitly (previously case_clause
  crash); spend a token only for {ok, Pid} and maxlimit/forbidden; every
  failure before a connection process exists (MFA errors/crashes, tune
  failures incl. closed) spends nothing
- esockd_connection_sup: keep the peer endpoint (raw {Addr, Port}, already
  fetched for access rules) in the existing curr_connections map instead
  of a per-connection process-dictionary entry; the local listener address
  is cached once per supervisor (constant memory); pre-upgrade 'true' map
  values are handled on exit
- esockd_server/esockd_listener_sup: restore synchronous init_stats as a
  startup barrier so a pending del_stats from a previously stopped
  listener cannot wipe a reopened listener's counters; sock-error counters
  stay lazy
- esockd_dtls_acceptor: handle the tagged peername failure and ignore

Tests: ignore handling (acceptor + connection-sup), peername tagging;
16/16 suites pass.

35 of 61 new or added lines in 5 files covered. (57.38%)

756 of 1104 relevant lines covered (68.48%)

201.85 hits per line